RFR: 8266773: Release VM is broken with GCC 9 after JDK-8214237

Leo Korinth lkorinth at openjdk.java.net
Mon May 10 13:29:59 UTC 2021


On Mon, 10 May 2021 09:39:40 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> The string version ("%*s") of mine is better as it will correctly indent the zero indentation case.
>
>> Maybe instead use something like:
>> `out->print("%*s%s", 2 * indent_level, "", "indented*s");`
>> or:
>> `out->print("%*c%s", 2 * indent_level, ' ', "indented*c");`
>> 
>> And get rid of the "Indents" string array and associated functions.
> 
> Good suggestion!
> 
> Thanks @lkorinth .
> Will update it later if there is no objection.

https://github.com/openjdk/jdk/pull/3934 solves the same problem via out->sp(indent_level * 2); please coordinate the fix with @tstuefe, and whatever solution you chose to use, please remove all of the old usages of indent().

-------------

PR: https://git.openjdk.java.net/jdk/pull/3941



More information about the hotspot-gc-dev mailing list