Integrated: JDK-8266802: Shenandoah: Round up region size to page size unconditionally
Aleksey Shipilev
shade at openjdk.java.net
Mon May 10 20:32:16 UTC 2021
On Mon, 10 May 2021 08:35:06 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Since JDK-8265239, runtime/os/TestTracePageSizes.java fails with Shenandoah like this:
>
>
> # Internal Error (/home/buildbot/worker/test-jdkX-linux/build/src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp:156), pid=55712, tid=55720
> # assert(_num_regions == (max_byte_size / reg_size_bytes)) failed: Must match
>
>
> This is because Shenandoah region sizes are rounded up to page size only when `ShenandoahUncommit` is true. In the failing test configuration, `ShenandoahUncommit` is false, because Xmx == Xms.
>
> Additional testing:
> - [x] New regression test, now passes
> - [x] `tier1` with Shenandoah
This pull request has now been integrated.
Changeset: e5d3ee39
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/e5d3ee394ae940ee0111489e6e072f327ec29c3b
Stats: 76 lines in 3 files changed: 71 ins; 0 del; 5 mod
8266802: Shenandoah: Round up region size to page size unconditionally
Reviewed-by: zgu
-------------
PR: https://git.openjdk.java.net/jdk/pull/3945
More information about the hotspot-gc-dev
mailing list