RFR: 8266773: Release VM is broken with GCC 9 after 8214237 [v2]

[Thomas Stuefe]

On Mon, 10 May 2021 23:44:53 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hi all,
>> 
>> Release VM is broken with GCC 9 due to -Werror=format-overflow=.
>> And if this assert[1] is removed, fastdebug VM can also reproduce the same bug.
>> The key to reproduce it is to compile with -O3.
>> 
>> IMO, it seems like a false positive gcc bug.
>> But we'd better fix it since gcc 9 is assumed to be supported to build OpenJDK.
>> 
>> Thanks.
>> Best regards,
>> Jie
>> 
>> 
>> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp#L47
>
> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove all of the old usages of indent()

hi @DamonFool ,

Thanks for tackling this! Feel free to go forward with your patch, I'll withdraw mine.

You patch looks fine. Nit: having a constant for chars-per-indentation would be nice instead of the literal 2 and "  ". But I don't have strong emotions.

Cheers, Thomas

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3941