RFR: 8266845: Shenandoah: Simplify SBS::load_reference_barrier implementation [v2]
Zhengyu Gu
zgu at openjdk.java.net
Tue May 11 12:36:46 UTC 2021
On Tue, 11 May 2021 12:21:56 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Aleksey's comments
>
> src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp line 130:
>
>> 128:
>> 129: oop fwd = load_reference_barrier(obj);
>> 130: assert(fwd != nullptr, "Sanity");
>
> `nullptr` -> `NULL` here too. Actually, why do we need this assert? I don't mind leaving it, if there is a reason.
No good reason. I removed it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3956
More information about the hotspot-gc-dev
mailing list