RFR: 8257774: G1: Trigger collect when free region count drops below threshold to prevent evacuation failures [v6]

[Aditya Mandaleeka]

On Mon, 17 May 2021 20:38:59 GMT, Aditya Mandaleeka <adityam at openjdk.org> wrote:

>> _This PR picks up from [this previous PR](https://github.com/openjdk/jdk/pull/1650) by @charliegracie._
>> 
>> I won't repeat the full description from the prior PR, but the general idea is to add the notion of a "proactive GC" to G1 which gets triggered in the slow allocation path if the number of free regions drops below the amount that would be required to complete a GC if it happened at that moment. The threshold is based on the survival rates from eden and survivor spaces along with the space required for tenured space evacuations.
>> 
>> There are a couple of outstanding issues/questions known:
>> - [Update: This has been resolved] _Interaction with GCLocker_: In the case where we determine that a proactive GC is required and GC locker is active, we don't allow the young gen to expand (instead threads will stall). @tschatzl raised this and suggested that it should be discussed as part of the review.
>> - [Update: This has been resolved] _Disable proactive GC heuristic during initialization_: I ran into an issue in testing where code in the universe initialization codepath was tripping the proactive GC heuristic, leading to a GC being triggered before the VM has finished initialization. I need to find a good way to prevent this from happening. There may already be a mechanism for this, but I couldn't find one so I added a temporary placeholder (`zzinit_complete`) just to unblock testing.
>
> Aditya Mandaleeka has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor updates/feedback.

In the interest of completeness, I re-ran the Renaissance-Scrabble benchmark with the latest updates (even though there is no reason to believe they'd affect the results). I also re-ran the "before" test.

Before (https://github.com/adityamandaleeka/jdk/commit/28c35aedd38c5d3b3053c737a65e0294e4606d65):

Result "org.renaissance.jdk.streams.JmhScrabble.runOperation":
  N = 150
  mean =    352.325 ±(99.9%) 3.266 ms/op


After (https://github.com/openjdk/jdk/pull/3143/commits/57421e1e44f3382eedb93ef07a72f62019500897):

Result "org.renaissance.jdk.streams.JmhScrabble.runOperation":
  N = 150
  mean =    354.977 ±(99.9%) 2.666 ms/op



As before, I'm not seeing the delta that was reported. @tschatzl Please let me know if you're still seeing the regression and we can figure out if perhaps I'm doing something different than you. Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3143