RFR: 8264408: test_oopStorage no longer needs to disable some tests on WIN32
Thomas Stuefe
stuefe at openjdk.java.net
Tue May 18 06:47:04 UTC 2021
The gtest gc/shared/test_oopStorage.cpp disables some tests on 32bit Windows because they use SafeFetch, which couldn't be used in the context where these tests were run. JDK-8185734 tracked the problem of using SafeFetch in gtests, and has since been fixed. So the OopStorage tests no longer need to be disabled.
Removing the test suppression involves removing the macro DISABLE_GARBAGE_ALLOCATION_STATUS_TEST and the #ifndef uses of it from test_oopStorage.cpp.
Note that the condition for defining that macro was botched, so that it applied to all Windows platforms, not just 32bit Windows. So the relevant tests haven't been executed on any version of Windows.
-------------
Commit messages:
- remove windows special handling
Changes: https://git.openjdk.java.net/jdk/pull/4026/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4026&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8264408
Stats: 11 lines in 1 file changed: 0 ins; 11 del; 0 mod
Patch: https://git.openjdk.java.net/jdk/pull/4026.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4026/head:pull/4026
PR: https://git.openjdk.java.net/jdk/pull/4026
More information about the hotspot-gc-dev
mailing list