RFR: 8264408: test_oopStorage no longer needs to disable some tests on WIN32

[Thomas Stuefe]

On Tue, 18 May 2021 07:03:14 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> The gtest gc/shared/test_oopStorage.cpp disables some tests on 32bit Windows because they use SafeFetch, which couldn't be used in the context where these tests were run. JDK-8185734 tracked the problem of using SafeFetch in gtests, and has since been fixed. So the OopStorage tests no longer need to be disabled.
>> 
>> Removing the test suppression involves removing the macro DISABLE_GARBAGE_ALLOCATION_STATUS_TEST and the #ifndef uses of it from test_oopStorage.cpp.
>> 
>> Note that the condition for defining that macro was botched, so that it applied to all Windows platforms, not just 32bit Windows. So the relevant tests haven't been executed on any version of Windows.
>
> Looks good to me. 
> 
> Oh wow, Microsoft docs on predefined macros: "_WIN32 Defined as 1 when the compilation target is 32-bit ARM, 64-bit ARM, x86, or x64. Otherwise, undefined."

Thanks @shipilev and @tschatzl .

-------------

PR: https://git.openjdk.java.net/jdk/pull/4026