Integrated: 8264408: test_oopStorage no longer needs to disable some tests on WIN32

Thomas Stuefe stuefe at openjdk.java.net
Tue May 18 08:55:50 UTC 2021


On Fri, 14 May 2021 06:27:37 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> The gtest gc/shared/test_oopStorage.cpp disables some tests on 32bit Windows because they use SafeFetch, which couldn't be used in the context where these tests were run. JDK-8185734 tracked the problem of using SafeFetch in gtests, and has since been fixed. So the OopStorage tests no longer need to be disabled.
> 
> Removing the test suppression involves removing the macro DISABLE_GARBAGE_ALLOCATION_STATUS_TEST and the #ifndef uses of it from test_oopStorage.cpp.
> 
> Note that the condition for defining that macro was botched, so that it applied to all Windows platforms, not just 32bit Windows. So the relevant tests haven't been executed on any version of Windows.

This pull request has now been integrated.

Changeset: da7c846a
Author:    Thomas Stuefe <stuefe at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/da7c846a8c52c32babae1c545aa17d4b9bd85e76
Stats:     11 lines in 1 file changed: 0 ins; 11 del; 0 mod

8264408: test_oopStorage no longer needs to disable some tests on WIN32

Reviewed-by: shade, tschatzl

-------------

PR: https://git.openjdk.java.net/jdk/pull/4026



More information about the hotspot-gc-dev mailing list