RFR: 8266746: C1: Replace UnsafeGetRaw with UnsafeGetObject when setting up OSR entry block [v2]
Tobias Hartmann
thartmann at openjdk.java.net
Fri May 21 07:56:29 UTC 2021
On Thu, 20 May 2021 02:40:27 GMT, Yi Yang <yyang at openjdk.org> wrote:
>> src/hotspot/share/c1/c1_Instruction.hpp line 2318:
>>
>>> 2316:
>>> 2317: // accessors
>>> 2318: bool is_raw_get() { return _is_raw_get; }
>>
>> I would rename this to `_is_raw` because we already know it's a get.
>
> Thanks Tobias for the review! All fixed. I will test it on Linux(already tested)/Mac/Windows(aarch64+x86_64) later. But I don't have ppc and s390 machines so I'm not sure how to test it on them...
Looks good. Maybe someone from the OpenJDK community can run some sanity testing on ppc/s390.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3917
More information about the hotspot-gc-dev
mailing list