RFR: 8267311: vmTestbase/gc/gctests/StringInternGC/StringInternGC.java eventually OOMEs [v4]

[Thomas Schatzl]

On Fri, 21 May 2021 14:11:33 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hi all,
>> 
>> vmTestbase/gc/gctests/StringInternGC/StringInternGC.java fails with release VM on our many-core machines due to `-XX:MaxRAMPercentage=0`.
>> This is because `-XX:MaxRAMPercentage=0` will be 0 if JTREG_JOBS > 25 [1].
>> 
>> Reproduce:
>>  - make test TEST="vmTestbase/gc/gctests/StringInternGC/StringInternGC.java" JTREG="JOBS=26" CONF=server-release
>> 
>> `-Xmx1g` is added to make it more robust.
>> Note: we still see failure with `-Xmx512m`.
>> 
>> Thanks.
>> Best regards,
>> Jie
>> 
>> [1] https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L741
>
> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add regular full gc

Changes requested by tschatzl (Reviewer).

test/hotspot/jtreg/vmTestbase/gc/gctests/StringInternGC/StringInternGC.java line 62:

> 60:                         }
> 61: 
> 62:                         long currentTime = System.currentTimeMillis();

Please move the `system.gc()` call (and the time calculation) into the caller of this method.  Having a method called `generateString()` do a `system.gc()` seems quite surprising.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4086