RFR: 8267836: Separate eager reclaim remembered set threshold from G1RSetSparseRegionEntries [v2]

Thomas Schatzl tschatzl at openjdk.java.net
Mon May 31 12:16:43 UTC 2021


On Mon, 31 May 2021 11:05:53 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   lkorinth review
>
> src/hotspot/share/gc/g1/g1Arguments.cpp line 58:
> 
>> 56:   // on it.
>> 57:   if (FLAG_IS_DEFAULT(G1EagerReclaimRemSetThreshold)) {
>> 58:       guarantee(G1RSetSparseRegionEntries > 0, "");
> 
> please reduce "guarantee()" indentation and  consider not using an empty string

This has been a leftover debug code. I'll remove it, sorry.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4248



More information about the hotspot-gc-dev mailing list