RFR: 8272773: Investigate making card table size configurable [v4]

[Kim Barrett]

On Tue, 12 Oct 2021 10:29:01 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Actually I've kept the names of all the pre-existing constants (which are now variables) same as before. Otherwise we have to change all the references also.
>
> Let's see what the second reviewer thinks. Otherwise this can be done separately as it might hide the interesting part of this change.

Not a review (yet), just a response to these questions.

Public data members are very rare in HotSpot code.  There are a few POD/standard layout classes (examples include G1BufferNodeList and OopStorage::BasicParState::IterationData), but otherwise accessor functions are preferred.  The style-guide says
"Use public accessor functions for member variables accessed outside the class."

The style-guide says this:
"Class data member names have a leading underscore, and use lowercase with words separated by a single underscore (_foo_bar)."
It makes no distinction for public or not, or for static or not.  That is intentional, based on some discussion about that question when I was updating the style-guide a while ago.

Of course, there are probably counter-examples to both of these lurking in the code base.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5838