RFR: 8277428: G1: Move and inline G1STWIsAliveClosure::do_object_b [v2]

Stefan Johansson sjohanss at openjdk.java.net
Fri Nov 19 13:17:47 UTC 2021


On Fri, 19 Nov 2021 11:34:21 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> This is a trivial patch to move G1STWIsAliveClosure::do_object_b definition to the right file g1CollectedHeap.inline.hpp.
>
> Hamlin Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into move-G1STWIsAliveClosure-do_object_b
>  - Inline G1STWIsAliveClosure::do_object_b
>  - Initial commit

A lot of the changes to include `g1CollectedHeap.inline.hpp` look strange to me, are they really needed? And the normal `hpp`-files that now include it are wrong, we should never have normal `hpp`-files including `inline.hpp`-files.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6470



More information about the hotspot-gc-dev mailing list