RFR: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm

[Thomas Schatzl]

On Tue, 5 Oct 2021 10:02:21 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this fix of the test, eliminating a race that could
> unexpectedly leave buffers in the "completed" list after all the threads
> have shut down.
> 
> Testing:
> mach5 tier1

Lgtm apart from the mentioned (imho) comment inaccuracy.

test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp line 191:

> 189:         return;
> 190:       } else if (!Atomic::load_acquire(_continue_running)) {
> 191:         // To avoid a race that could leave buffers in the list after this

s/avoid/handle/ (or something similar).

The change does not eliminate (or avoids) the race, but handles the (not logic-breaking) results of the race.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5820