RFR: 8274927: Remove unnecessary G1ArchiveAllocator code
Thomas Schatzl
tschatzl at openjdk.java.net
Fri Oct 8 13:07:07 UTC 2021
On Fri, 8 Oct 2021 12:53:49 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> The change looks good. Since `_archive_allocator` is often null, I wonder if this means the field should be moved to another place.
That has been my initial reaction too when I noticed this. However there is no really good place. In a discussion with @iklam he suggested `ArchiveBuilder`, but before experimenting with that (it does not seem perfect either, particularly because this would require lots of ifdef-ing in builds without G1) I thought this change was good enough to stand on its own.
Thanks @albertnetymk and @kimbarrett for your reviews.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5861
More information about the hotspot-gc-dev
mailing list