Integrated: 8274927: Remove unnecessary G1ArchiveAllocator code
Thomas Schatzl
tschatzl at openjdk.java.net
Mon Oct 11 11:50:18 UTC 2021
On Fri, 8 Oct 2021 07:14:08 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I have reviews for this change that removes code that is fairly trivially recognizable as useless?
>
> The `_archive_allocator` is always freed after use (see `HeapShared::copy_closed/open_objects`), so it must always be `nullptr` when it's accessed outside the CDS dump code.
> I kept the asserts in the original places, but idk if that is really necessary.
>
> Testing: tier1-5
This pull request has now been integrated.
Changeset: aaf2401b
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/aaf2401bc7d766dee5ffc623db86c4723c7e3760
Stats: 36 lines in 3 files changed: 0 ins; 26 del; 10 mod
8274927: Remove unnecessary G1ArchiveAllocator code
Reviewed-by: kbarrett, ayang
-------------
PR: https://git.openjdk.java.net/jdk/pull/5861
More information about the hotspot-gc-dev
mailing list