RFR: 8273626: G1: Factor out concurrent segmented array from G1CardSetAllocator [v4]

Hamlin Li mli at openjdk.java.net
Thu Oct 14 09:05:53 UTC 2021


On Wed, 13 Oct 2021 11:44:55 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refine code
>
> src/hotspot/share/gc/g1/g1SegmentedArray.hpp line 150:
> 
>> 148:   }
>> 149: 
>> 150:   uint next_num_elems(uint prev_num_elems) {
> 
> Probably it's best to define this as virtual abstract and override as needed in subclasses. Or just keep the implementation from `G1CardSetAllocOptions` here for now.

I'm afraid I have missed something more important, _alloc_options in G1SegmentedArray should be a pointer rather than value, as its behaviour should be polymorphic, so I also made more changes to address this issue in g1CardSetMemory.cpp, g1CardSet.cpp/hpp.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5478



More information about the hotspot-gc-dev mailing list