Integrated: 8274910: Compile in G1 evacuation failure injection code based on define

[Thomas Schatzl]

On Thu, 7 Oct 2021 14:25:04 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this change that simplifies performance work with evacuation failure handling a little? In particular, it adds a define called `EVAC_FAILURE_INJECTOR` (on by default in non-product builds) that allows to compile in/out the relevant injector code also in product mode (if manually enabled).
> 
> Actually, this PR suggests two variants for this: one that also automatically enables flags when `EVAC_FAILURE_INJECTOR` is selected (beaa6c3), and one that requires the developer also change the options from develop/notproduct to product to be available (9f07ffd).
> 
> The first is maybe makes the change a bit too hacky in `g1_globals.hpp` (unless there are ways to do that better, i.e. I could move the `GC_G1_EVACUATION_FAILURE_FLAGS` somewhere, or there is a much better preprocessor trick here, so I would like to have you decide.
> 
> Testing: gha, manual checking that in product mode by default no evacuation failure handling is in, but with the flag, and otherwise the same as before, tier1-5
> 
> Thanks,
>   Thomas

This pull request has now been integrated.

Changeset: 50a57238
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/50a57238a8e34a976354b1de91c14cddacb3d88f
Stats:     122 lines in 6 files changed: 77 ins; 29 del; 16 mod

8274910: Compile in G1 evacuation failure injection code based on define

Reviewed-by: sjohanss, ayang

-------------

PR: https://git.openjdk.java.net/jdk/pull/5851