RFR: 8274988 G1: refine G1SegmentedArrayAllocOptions and G1CardSetAllocOptions

[Thomas Schatzl]

On Wed, 20 Oct 2021 08:41:01 GMT, Hamlin Li <mli at openjdk.org> wrote:

> This is a follow-up of JDK-8273626. (something mentioned in Description was already done in JDK-8273626)
> Some other cleanups need to be done:
> Some fields of G1SegmentedArrayAllocOptions better be reloated to G1CardSetAllocOptions, and some fields are const, and also adds some assert.

Marked as reviewed by tschatzl (Reviewer).

src/hotspot/share/gc/g1/g1CardSetMemory.hpp line 57:

> 55: 
> 56:   virtual uint next_num_elems(uint prev_num_elems) const override {
> 57:     assert(_alignment == BufferAlignment, "Must be");

I think this is unnecessary - we pass that value in the constructor and it is `const`, so there is a high chance this is correct.

Lgtm otherwise, I do not need to re-review if you decide to drop this assert.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6032