RFR: 8272563: assert(is_double_stack() && !is_virtual()) failed: type check [v4]

[Fairoz Matte]

> This patch is proposed by the submitter of the bug - ugawa at ci.i.u-tokyo.ac.jp
> 
> The method CardTableBarrierSetC1::post_barrier generates a move LIR when TwoOperandLIRForm flag is true to move the address to be marked in the card table to a temporary register.
>> __ move(addr, tmp);
> However, this code only guarantees that `addr` is a valid register for LIR, which can be a virtual register. If the virtual register for `addr` is spilled to the stack by chance, the `move(addr, tmp)` is compiled to a memory-to-register which causes an assertion failure because a memory-to-register move requires their arguments to have the same size. 
> The fix is to check if it is is_oop() and call the mov appropriately.
> 
> No issues found in local testing and Mach5 tier1-3

Fairoz Matte has updated the pull request incrementally with one additional commit since the last revision:

  8272563: Possible assertion failure in CardTableBarrierSetC1

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5164/files
  - new: https://git.openjdk.java.net/jdk/pull/5164/files/5c1e1d49..359cbf3d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5164&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5164&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5164.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5164/head:pull/5164

PR: https://git.openjdk.java.net/jdk/pull/5164