RFR: 8254167 G1: Record regions where evacuation failed to provide targeted iteration [v4]

Thomas Schatzl tschatzl at openjdk.java.net
Thu Sep 2 13:25:38 UTC 2021


On Thu, 2 Sep 2021 11:08:51 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Either that, or provide a data structure that encapsulates an array that items can be atomically added to including the iteration.
>
> Do you mean to just do some refactoring for G1EvacuationFailureRegions or for hrm/cset together?

Actually, the collection set does not need the atomicity of addition to the array. So, probably it's best for this change to factor out the iteration over an array of heap region indexes into a `G1CollectedHeap`(probably the best place for now?) method which you pass the array information too - to be used in both places.

There is imho no point in delaying this into a separate CR, it's just one method and two uses afaict.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5272



More information about the hotspot-gc-dev mailing list