RFR: 8272985: Reference discovery is confused about atomicity and degree of parallelism [v2]
Albert Mingkun Yang
ayang at openjdk.java.net
Fri Sep 3 12:03:22 UTC 2021
On Tue, 31 Aug 2021 11:36:51 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> can I have reviews for this change that fixes some (apparent) confusion between atomicity (of the discovery in the `ReferenceProcessor` sense) vs. the currently selected degree of parallelism?
>>
>> For all four different combinations of atomicity and parallelism the `discovered` link in the `java.lang.ref.Reference` needs to be updated differently using a different kind of access, instead of just two based on atomicity.
>>
>> I'll fix the use of `atomic` in `ReferenceProcessor` in a separate CR to hopefully remove the confusion for the reader too.
>>
>> Testing: tier1-5, internal perf benchmarks without regressions
>>
>> Thanks,
>> Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>
> Some more refactorng
Marked as reviewed by ayang (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/5314
More information about the hotspot-gc-dev
mailing list