RFR: 8272905: Consolidate discovered lists processing [v2]

Kim Barrett kbarrett at openjdk.java.net
Fri Sep 3 15:38:28 UTC 2021


On Tue, 31 Aug 2021 14:11:49 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Simple change of merging discovered list processing for four kinds of non-strong refs and some general cleanup around.
>> 
>> Test: tier1-3
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review

Looks good.  Just a couple very minor nits.  I re-examined the discussion and change for JDK-8202845 as part of examining this.

src/hotspot/share/gc/shared/referenceProcessor.cpp line 427:

> 425:   ReferenceProcessor::RefProcSubPhases subphase;
> 426:   DiscoveredList* dl;
> 427:   switch(ref_type) {

Missing space after "switch" per style guide.

src/hotspot/share/gc/shared/referenceProcessor.cpp line 448:

> 446:   }
> 447: 
> 448:   // Only Final refs are not enqueued.

s/enqueued./enqueued and cleared here./

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5242



More information about the hotspot-gc-dev mailing list