Integrated: 8272985: Reference discovery is confused about atomicity and degree of parallelism
Thomas Schatzl
tschatzl at openjdk.java.net
Mon Sep 6 09:11:42 UTC 2021
On Tue, 31 Aug 2021 09:19:37 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I have reviews for this change that fixes some (apparent) confusion between atomicity (of the discovery in the `ReferenceProcessor` sense) vs. the currently selected degree of parallelism?
>
> For all four different combinations of atomicity and parallelism the `discovered` link in the `java.lang.ref.Reference` needs to be updated differently using a different kind of access, instead of just two based on atomicity.
>
> I'll fix the use of `atomic` in `ReferenceProcessor` in a separate CR to hopefully remove the confusion for the reader too.
>
> Testing: tier1-5, internal perf benchmarks without regressions
>
> Thanks,
> Thomas
This pull request has now been integrated.
Changeset: fb5b144e
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/fb5b144eca761d4b4c667efe05ca638536c065ac
Stats: 82 lines in 3 files changed: 44 ins; 20 del; 18 mod
8272985: Reference discovery is confused about atomicity and degree of parallelism
Reviewed-by: ayang, kbarrett
-------------
PR: https://git.openjdk.java.net/jdk/pull/5314
More information about the hotspot-gc-dev
mailing list