RFR: 8254167 G1: Record regions where evacuation failed to provide targeted iteration [v6]

Thomas Schatzl tschatzl at openjdk.java.net
Mon Sep 6 09:53:49 UTC 2021


On Mon, 6 Sep 2021 09:48:18 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactor par iteration for regions of cset and evac failure.
>
> src/hotspot/share/gc/g1/g1EvacFailureRegions.hpp line 28:
> 
>> 26: #define SHARE_GC_G1_G1EVACFAILUREREGIONS_HPP
>> 27: 
>> 28: #include "utilities/bitMap.inline.hpp"
> 
> need "runtime/atomic.hpp" too (or so) for the `Atomic` operations uses.

We do not allow includes of `.inline.hpp` files in `.hpp` files to avoid issues with circular dependencies. The `record` method needs to be put into an `.inline.hpp` file due to the use of `par_set_bit`.

Sorry for not noticing earlier.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5272



More information about the hotspot-gc-dev mailing list