RFR: 8273372: More precise ResourceMark in ReferenceProcessor

[Thomas Schatzl]

On Mon, 6 Sep 2021 08:26:37 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple change of moving `ResourceMark` closer to where it is actually required.
> 
> Test: tier1-6

I did some looking whether there are similar places to look out for, but found nothing.

Also, I would not be opposed to completely remove that trace message: while trace messages may slow down the garbage collection significantly, this message probably does so way too much to be useful for any kind of output; I understand that this message is enabled in development builds only too, but the other collectors do not have similar messages anyway. Additionally, even when debugging it helps much more to have some a bit more targeted log message; this is kind of a last resort to dump *everything*. At that point during debugging adding just another log message is probably not too much of a bother (as you probably have exhausted all other options and littered the code with such messages already. I "know" because I just went through that exercise with another issue in g1, and that single one message wouldn't have helped me in any significant way).

So long story short, if you want to remove that message fine with me, but it might be a good idea to consider other opinions too.

So lgtm.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5375