RFR: 8273185: Rename the term "atomic" in ReferenceProcessor
Aleksey Shipilev
shade at openjdk.java.net
Wed Sep 8 08:31:10 UTC 2021
On Tue, 7 Sep 2021 18:58:53 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review this suggestion to rename the term "atomic" in the `ReferenceProcessor` class to "concurrent"/"stw" to avoid the confusion with Atomic operations.
>
> It's a smaller change than expected, which is good, but also might question the need for this change. I grepped for "atomic" in the reference processor sources and hopefully got everything.
>
> Testing: tier1-5
>
> Thanks,
> Thomas
This looks fine to me, with one nit.
src/hotspot/share/gc/shared/referenceProcessor.cpp line 905:
> 903: "Bad referent " INTPTR_FORMAT " found in Reference "
> 904: INTPTR_FORMAT " during %sconcurrent discovery ",
> 905: p2i(referent), p2i(obj), concurrent ? "non-" : "");
This seems backwards, shouldn't it be `concurrent ? "" : "non-"`?
-------------
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5397
More information about the hotspot-gc-dev
mailing list