RFR: 8273476: G1: refine G1CollectedHeap::par_iterate_regions_array_part_from [v2]
Hamlin Li
mli at openjdk.java.net
Thu Sep 9 01:10:41 UTC 2021
On Wed, 8 Sep 2021 12:17:44 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> refine comments and code
>
> src/hotspot/share/gc/g1/g1CollectedHeap.hpp line 1161:
>
>> 1159: // the given HeapRegionClosure on each region. The worker_id will determine where
>> 1160: // in the part to start the iteration to allow for more efficient parallel iteration.
>> 1161: void par_iterate_regions_array_part_from(HeapRegionClosure* cl,
>
> The comment needs to be updated as well. `const uint* regions` can be written as `const uint regions[]` to make the concept clearer, IMO.
I have modified the function name too.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5414
More information about the hotspot-gc-dev
mailing list