RFR: 8273476: G1: refine G1CollectedHeap::par_iterate_regions_array_part_from [v4]

Thomas Schatzl tschatzl at openjdk.java.net
Thu Sep 9 08:09:06 UTC 2021


On Thu, 9 Sep 2021 06:47:26 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> G1CollectedHeap::par_iterate_regions_array_part_from is moved from G1CollectionSet::iterate_part_from in JDK-8254167.
>> The parameters and logic of this method could be refined a bit to make it more straight.
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix issue

Changes requested by tschatzl (Reviewer).

src/hotspot/share/gc/g1/g1CollectionSet.cpp line 238:

> 236:                                   hr_claimer,
> 237:                                   &_collection_set_regions[offset],
> 238:                                   length,

This should be `length - offset`, shouldn't it?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5414



More information about the hotspot-gc-dev mailing list