RFR: 8273476: G1: refine G1CollectedHeap::par_iterate_regions_array_part_from [v4]

Albert Mingkun Yang ayang at openjdk.java.net
Thu Sep 9 08:14:01 UTC 2021


On Thu, 9 Sep 2021 06:47:26 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> G1CollectedHeap::par_iterate_regions_array_part_from is moved from G1CollectionSet::iterate_part_from in JDK-8254167.
>> The parameters and logic of this method could be refined a bit to make it more straight.
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix issue

src/hotspot/share/gc/g1/g1CollectedHeap.hpp line 1158:

> 1156:   }
> 1157:   void collection_set_iterate_increment_from(HeapRegionClosure *blk, HeapRegionClaimer* hr_claimer, uint worker_id);
> 1158:   // Iterate an array of region indexes given by offset and length, applying

Since there's no `offset` in the signature, how about "Iterate over the array, `uint regions[length]`, applying ..."?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5414



More information about the hotspot-gc-dev mailing list