RFR: 8273476: G1: refine G1CollectedHeap::par_iterate_regions_array_part_from [v4]
Hamlin Li
mli at openjdk.java.net
Thu Sep 9 09:14:00 UTC 2021
On Thu, 9 Sep 2021 09:06:41 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> src/hotspot/share/gc/g1/g1CollectionSet.cpp line 238:
>>
>>> 236: hr_claimer,
>>> 237: &_collection_set_regions[offset],
>>> 238: length,
>>
>> This should be `length - offset`, shouldn't it?
>
> Suggestion:
>
> length - offset,
>
>
> Untested :)
I thought so too at first, but seems it's not.
The passed in length in both G1CollectionSet::par_iterate/iterate_incremental_part_from are both the length of the "sub" array already. ( increment_length() is passed as length in iterate_incremental_part_from)
How do you think about it?
-------------
PR: https://git.openjdk.java.net/jdk/pull/5414
More information about the hotspot-gc-dev
mailing list