RFR: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah [v2]

Zhengyu Gu zgu at openjdk.java.net
Fri Sep 10 12:48:09 UTC 2021


On Fri, 10 Sep 2021 12:30:32 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Aleksey's comment
>
> test/hotspot/jtreg/gc/stringdedup/TestStringDeduplicationTools.java line 102:
> 
>> 100:             if (n.getType().equals(GarbageCollectionNotificationInfo.GARBAGE_COLLECTION_NOTIFICATION)) {
>> 101:                 GarbageCollectionNotificationInfo info = GarbageCollectionNotificationInfo.from((CompositeData) n.getUserData());
>> 102:                 // Shenandoah GC also report GC pauses, skip them
> 
> Suggestion:
> 
>                 // Shenandoah GC also reports GC pauses, skip them

Fixed

> test/hotspot/jtreg/gc/stringdedup/TestStringDeduplicationTools.java line 105:
> 
>> 103:                 if (info.getGcName().startsWith("Shenandoah")) {
>> 104:                     if ("end of GC cycle".equals(info.getGcAction())) {
>> 105:                         gcCount ++;
> 
> Suggestion:
> 
>                         gcCount++;

Fixed

> test/hotspot/jtreg/gc/stringdedup/TestStringDeduplicationTools.java line 108:
> 
>> 106:                     }
>> 107:                 } else {
>> 108:                     gcCount ++;
> 
> Suggestion:
> 
>                     gcCount++;

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/5428



More information about the hotspot-gc-dev mailing list