RFR: 8273559: Shenandoah: Shenandoah should support multi-threaded heap dump [v2]

Zhengyu Gu zgu at openjdk.java.net
Mon Sep 13 12:35:59 UTC 2021


On Mon, 13 Sep 2021 10:09:15 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Aleksey and Severin's comments
>
> src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp line 263:
> 
>> 261:    assert(Thread::current()->is_VM_thread(), "Only by VM thread");
>> 262:    // Must use _claim_none to avoid interfering with concurrent CLDG iteration
>> 263:    CLDToOopClosure clds(oops, ClassLoaderData::_claim_other);
> 
> Nit: Update/remove comment? `Must use _claim_none ...` seems to conflict with code.

Fixed. Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/5473



More information about the hotspot-gc-dev mailing list