RFR: 8273559: Shenandoah: Shenandoah should support multi-threaded heap dump [v2]

[Zhengyu Gu]

On Mon, 13 Sep 2021 08:55:22 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Aleksey and Severin's comments
>
> src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp line 124:
> 
>> 122: 
>> 123: public:
>> 124:   ShenandoahClassLoaderDataRoots(ShenandoahPhaseTimings::Phase phase, uint n_workers, bool heapdump);
> 
> Can we call the new parameter `heap_iteration`? This would match the `ShenandoahHeapIterationRootScanner` name. I could also imagine that iteration is used for something else than a heap dump (maybe JFR/JVMTI heap walk for profiling/debugging?).

Fixed. Thanks!

> test/hotspot/jtreg/gc/shenandoah/TestJcmdHeapDump.java line 156:
> 
>> 154:         }
>> 155:     }
>> 156: }
> 
> Newline is missing.

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/5473