RFR: 8274069: Clean up g1ParScanThreadState a bit [v2]
Albert Mingkun Yang
ayang at openjdk.java.net
Tue Sep 21 14:26:36 UTC 2021
On Tue, 21 Sep 2021 13:49:04 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> can I have reviews for this change that does some minor refactoring for issues found in JDK-8271880/PR#5037:
>>
>> - remove declaration without definition
>> - move inlined code into hpp file
>> - factor out some code
>>
>> Testing: gha, local compilation, local gc/g1
>>
>> Thanks,
>> Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>
> ayang review, renaming
The old name, `enqueue_card_after_barrier_filters`, is still referenced in the comments.
(I also wonder if it makes sense to unify all callers of `enqueue_card_if_tracked` to use `write_ref_field_post` with template non-type arguments. Not in PR ofc.)
-------------
Marked as reviewed by ayang (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5607
More information about the hotspot-gc-dev
mailing list