RFR: 8274069: Clean up g1ParScanThreadState a bit [v3]

[Kim Barrett]

On Tue, 21 Sep 2021 14:45:15 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this change that does some minor refactoring for issues found in JDK-8271880/PR#5037:
>> 
>> - remove declaration without definition
>> - move inlined code in the .hpp file into .inline.hpp file
>> - factor out some code
>> 
>> Testing: gha, local compilation, local gc/g1
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   ayang review, fixed comment

Does this change allow this inclusion of an .inline.hpp to be moved out of the .hpp?
33 #include "gc/g1/heapRegionRemSet.inline.hpp"

src/hotspot/share/gc/g1/g1ParScanThreadState.hpp line 132:

> 130: 
> 131:   // Apply the post barrier to the given reference field. Enqueues the card of p
> 132:   // if the barrier (same region, not from survivor) does not filter out not find

I don't understand this comment; seems like there's a grammar or wording problem.

-------------

Changes requested by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5607