RFR: 8274430: Remove some debug error printing code added in JDK-8017163
Thomas Schatzl
tschatzl at openjdk.java.net
Tue Sep 28 09:35:08 UTC 2021
Hi all,
can I have reviews for this change that undoes some logging changes from JDK-8017163, in particular it added the `XXX card set` lines in the output as shown in an example below:
``` [171.616s][1632757560415ms][error][gc,verify ] GC(129) Missing rem set entry:
[171.616s][1632757560415ms][error][gc,verify ] GC(129) Field 0x00000007fb1008f0 of obj 0x00000007fb1008d8 in region 1485:(O)[0x00000007fb000000,0x00000
[171.616s][1632757560415ms][error][gc,verify ] GC(129) NULL card setjava.lang.invoke.MethodType$ConcurrentWeakInternSet$WeakEntry
[...]
points to obj 0x00000004d9abd4c8 in region 683:(S)[0x00000004d9000000,0x00000004da000000,0x00000004da000000] remset Complete
This string would indicate which card set container does not have the requested remembered set entry. This is unnecessary information, as the "points to obj" string later shows that there should be a remset to this region already, and otherwise only interesting for debugging.
Testing: gha
Thanks,
Thomas
-------------
Commit messages:
- initial version
Changes: https://git.openjdk.java.net/jdk/pull/5733/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5733&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8274430
Stats: 3 lines in 1 file changed: 1 ins; 2 del; 0 mod
Patch: https://git.openjdk.java.net/jdk/pull/5733.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5733/head:pull/5733
PR: https://git.openjdk.java.net/jdk/pull/5733
More information about the hotspot-gc-dev
mailing list