RFR: 8274466 G1: simplify G1 collector states [v2]

Hamlin Li mli at openjdk.java.net
Thu Sep 30 01:34:29 UTC 2021


On Wed, 29 Sep 2021 12:38:25 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert wrong code
>
> src/hotspot/share/gc/g1/g1Policy.cpp line 604:
> 
>> 602:   bool result = false;
>> 603:   if (marking_request_bytes > marking_initiating_used_threshold) {
>> 604:     result = collector_state()->in_young_only_phase();
> 
> To me this looks like a change in behavior. The check you have removed is there to prevent requesting a new concurrent cycle when in the "Prepare Mixed" collections (the young GC preceding mixed collections).

Thanks for catching this, I have fixed it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5745



More information about the hotspot-gc-dev mailing list