RFR: 8283935: Parallel: Crash during pretouch after large pages allocation failure [v3]

[Albert Mingkun Yang]

On Tue, 5 Apr 2022 10:03:12 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this change that fixes a crash with Parallel GC, `AlwaysPretouch` and misconfigured large pages?
>> 
>> The `AlwaysPreTouch` code for Parallel GC does not use the actual used large page size for the heap, but the one passed in by the user. If that page size is not actually available, and the heap is not aligned to that used page size, there will be an out-of-bounds access by the pretouch code.
>> 
>> The change simply makes the code use the correct page size (which is passed in as `alignment` into `MutableSpace` - but that is another issue).
>> 
>> Testing: local testing of failing test case (see CR), tier1-3
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   kbarrett review - remove unused introduced method, page size calculation

Marked as reviewed by ayang (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8090