Integrated: 8283935: Parallel: Crash during pretouch after large pages allocation failure
Thomas Schatzl
tschatzl at openjdk.java.net
Wed Apr 6 08:05:42 UTC 2022
On Mon, 4 Apr 2022 11:07:09 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I have reviews for this change that fixes a crash with Parallel GC, `AlwaysPretouch` and misconfigured large pages?
>
> The `AlwaysPreTouch` code for Parallel GC does not use the actual used large page size for the heap, but the one passed in by the user. If that page size is not actually available, and the heap is not aligned to that used page size, there will be an out-of-bounds access by the pretouch code.
>
> The change simply makes the code use the correct page size (which is passed in as `alignment` into `MutableSpace` - but that is another issue).
>
> Testing: local testing of failing test case (see CR), tier1-3
>
> Thanks,
> Thomas
This pull request has now been integrated.
Changeset: b56df280
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/b56df2808d79dcc1e2d954fe38dd84228c683e8b
Stats: 10 lines in 3 files changed: 2 ins; 3 del; 5 mod
8283935: Parallel: Crash during pretouch after large pages allocation failure
Reviewed-by: kbarrett, ayang
-------------
PR: https://git.openjdk.java.net/jdk/pull/8090
More information about the hotspot-gc-dev
mailing list