RFR: 8280761: UseCompressedOops should be set after limit_heap_by_allocatable_memory [v2]
KIRIYAMA Takuya
duke at openjdk.java.net
Fri Apr 8 07:39:39 UTC 2022
On Thu, 7 Apr 2022 14:05:57 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8280761: UseCompressedOops should be set after limit_heap_by_allocatable_memory
>
> test/hotspot/jtreg/gc/arguments/TestUseCompressedOopsFlagsWithUlimit.java line 62:
>
>> 60:
>> 61: String cmd = ProcessTools.getCommandLine(ProcessTools.createTestJvm(args.toArray(String[]::new)));
>> 62: ProcessBuilder pb = new ProcessBuilder("sh", "-c", "ulimit -v 10485760;" + cmd);
>
> The `ulimit -v` parameter should be passed in as well like `MaxRAM`. Then, from the calling context, one can see whether coop should be enabled or not.
Thank you for your review.
> I don't understand why `MaxRAMPercentage` or `UseCompressedOops` are relevant to this fix/bug.
I forgot to remove this comment when I copied form TestMaxRAMFlags.java.
I fixed this comment.
> The `ulimit -v` parameter should be passed in as well like `MaxRAM`. Then, from the calling context, one can see whether coop should be enabled or not.
This bug appears when ulimit -v is specified and MaxRAM is set bigger value. So I think it does not need that
ulimit -v parameter let be variable.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7938
More information about the hotspot-gc-dev
mailing list