RFR: 8284572: Remove unneeded null check in ReferenceProcessor::discover_reference

[Thomas Schatzl]

Hi,

On 10.04.22 05:41, Kim Barrett wrote:
> On Fri, 8 Apr 2022 08:53:15 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> 
>> Simple change of removing an always-false if-check.
>>
>> Test: tier1-6
> 
> Looks good, now that we have JDK-8283415.
> 
> (Before JDK-8283415 someone could have potentially created a new
> direct subclass of Reference, though doing so would probably run into
> problems somewhere.)
> 
> I wonder if we could now completely eliminate REF_OTHER.  It looks
> like the only class that can have that ref-type (after JDK-8283415) is
> j.l.r.Reference.
> 

j.l.r.Reference is an abstract class, so I do not think there can be a 
direct instance.

Thomas