RFR: 8280761: UseCompressedOops should be set after limit_heap_by_allocatable_memory [v4]

Albert Mingkun Yang ayang at openjdk.java.net
Tue Apr 12 07:56:43 UTC 2022


On Tue, 12 Apr 2022 06:50:32 GMT, KIRIYAMA Takuya <duke at openjdk.java.net> wrote:

>> I fixed to set UseCompressedOops flag after limit_heap_by_allocatable_memory(). 
>> So when ulimit -v is called and -XX:MaxRAM is set, UseCompressedOops does not become false. 
>> And all hotspot tier1 test are passed.
>> Would you please review this fix?
>
> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8280761 UseCompressedOops should be set after limit_heap_by_allocatable_memory

Thank you for the revision. Embedding `ulimit -v` inside `checkFlag` still hinders readability, IMO.

What I have in mind is:


// ulimit, max_ram, max_ram_percent, expected_coop
checkFlag(5 * oneG, 32 * oneG, 100, true);


Then, it's clear in this context why coop is enabled.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7938



More information about the hotspot-gc-dev mailing list