RFR: 8291037: Move PLAB resizing mechanism to G1EvacStats [v2]

Ivan Walulya iwalulya at openjdk.org
Mon Aug 8 11:13:05 UTC 2022


On Tue, 26 Jul 2022 16:05:57 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this refactoring that moves the PLAB resizing mechanism to `G1EvacStats` as G1 is the only user for this functionality.
>> 
>> The change is split into two commits for easier review: 65eef6482cc0a995d29e822c9c26063bb42c7679 only moves the code,  028e3adeca1d496520f0c79f3b4bcedd7e7f0f15 tries to improve it a bit. 
>> 
>> Note that this change also removes the old, unused PLAB re-sizing algorithm previously used by CMS, hence the relatively large count of deleted LOC.
>> 
>> Testing: gha, gc/g1
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   improve one comment

Lgtm!

-------------

Marked as reviewed by iwalulya (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9644



More information about the hotspot-gc-dev mailing list