RFR: 8282729: Serial: Move BOT implementation to collector specific directory
Axel Boldt-Christmas
aboldtch at openjdk.org
Mon Aug 15 13:54:33 UTC 2022
On Mon, 15 Aug 2022 12:18:21 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> It's a bit surprising to see changes to other collectors in a commit titled "Serial: ...". I guess that's what you meant by "Move required fixing up some missing header files." I wonder if you can extract those fixes in another PR(s), which, IMO, would also make reviewing this PR slightly easier. Basically keeping each PR more focused.
It seems a bit ugly to leave the repository in an intermediate state where some headers are included only because there is something, somewhere else, that need that include. But if it makes the review easier I'll move
-#include "gc/shared/gc_globals.hpp"
-#include "memory/virtualspace.hpp"
into a different issue, so G1 and Epsilons still have all their required (indirect) includes.
-------------
PR: https://git.openjdk.org/jdk/pull/9662
More information about the hotspot-gc-dev
mailing list