RFR: 8287555: Tighten G1 G1BlockOffsetTable::block_start() code [v8]

Thomas Schatzl tschatzl at openjdk.org
Thu Aug 18 15:48:26 UTC 2022


On Tue, 12 Jul 2022 16:52:22 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this change that specializes `G1BlockOffsetTablePart::block_size` with a variant used for card aligned addresses including some cleanup of comments? This saves some unnecessary lookup of the block size of the object found as for refinement the start address is always aligned.
>> 
>> Testing: tier1, gha
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
> 
>  - Remove change
>  - Merge branch 'master' into pull/9059
>  - Merge branch 'master' into pull/9059
>  - Refactoring
>  - Improve merge, remove unneeded declarations
>  - Merge branch 'master' into pull/9059
>  - 828755:5 Tighten G1BlockOffsetTable::block_start() code
>    
>    initial version
>    
>    Cleanup
>  - Make block_start_reaching_into_card() const
>  - initial version

It has been determined that this is too much code complexity for this non-observable gain. Closing for now.

-------------

PR: https://git.openjdk.org/jdk/pull/9059



More information about the hotspot-gc-dev mailing list