RFR: 8288966: Better handle very spiky promotion in G1 [v3]

Thomas Schatzl tschatzl at openjdk.org
Mon Aug 22 09:11:37 UTC 2022


On Sat, 20 Aug 2022 21:19:05 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
>> 
>>  - Merge branch 'master' into 8288966-plab-boost
>>  - iwalulya review
>>  - Fix whitespace
>>  - Only boost with ResizePLAB
>>  - Refactoring, fix boundless boosting
>>  - some refinement
>>  - Some cleanup
>>  - More removal of conditional code
>>  - Optimize
>>  - some cleanup
>>  - ... and 2 more: https://git.openjdk.org/jdk/compare/7676be8a...ce2701cb
>
> Looks good.

Thanks @kimbarrett @walulyai for your reviews

> src/hotspot/share/gc/g1/g1ParScanThreadState.hpp line 155:
> 
>> 153:   // Pass locally gathered statistics to global state. Returns the total number of
>> 154:   // HeapWords copied.
>> 155:   size_t flush(size_t* surviving_young_words, uint num_workers);
> 
> [pre-existing] I dislike the name of this function.  Seems like it should be `flush_stats` or something like that.

I'll do a rename CR for that.

-------------

PR: https://git.openjdk.org/jdk/pull/9726



More information about the hotspot-gc-dev mailing list