RFR: 8291912: Introduce per-allocation target struct for members in G1PLABAllocator [v2]

Thomas Schatzl tschatzl at openjdk.org
Mon Aug 22 09:25:15 UTC 2022


> Hi all,
> 
>   can I get reviews for this change that refactors the many per-destination arrays in `PLABAllocator` into an array of struct as I promised in the review for [JDK-8288966](https://bugs.openjdk.org/browse/JDK-8288966)/[PR#9726](https://github.com/openjdk/jdk/pull/9726)? I think that makes the code easier to follow since there is less clutter.
> 
> Testing: tier1-5, no performance differences
> 
> Thanks,
>   Thomas

Thomas Schatzl has updated the pull request incrementally with 149 additional commits since the last revision:

 - Merge branch 'master' into 8291912-per-allocation-target-struct
 - 8288966: Better handle very spiky promotion in G1
   
   Reviewed-by: iwalulya, kbarrett
 - 8290249: Vectorize signum on AArch64
   
   Reviewed-by: aph, ngasson
 - 8253413: [REDO] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
   
   Reviewed-by: iwalulya, kbarrett
 - 8292318: Memory corruption in remove_dumptime_info
   
   Reviewed-by: coleenp, ccheung
 - 8290300: Use standard String-joining tools where applicable
   
   Reviewed-by: naoto, rriggs, dfuchs
 - 8292561: Make "ReplayCompiles" a diagnostic product switch
   
   Reviewed-by: kvn, xliu
 - 8292691: Move CompilerConfig::is_xxx() inline functions out of compilerDefinitions.hpp
   
   Reviewed-by: kvn, iveresov
 - 8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN"
   
   Reviewed-by: cjplummer, amenkov
 - 8292350: Use static methods for hashCode/toString primitives
   
   Reviewed-by: prr, rriggs, amenkov, jpai
 - ... and 139 more: https://git.openjdk.org/jdk/compare/a961fcdc...54c93338

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9818/files
  - new: https://git.openjdk.org/jdk/pull/9818/files/a961fcdc..54c93338

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9818&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9818&range=00-01

  Stats: 49389 lines in 742 files changed: 22278 ins; 22953 del; 4158 mod
  Patch: https://git.openjdk.org/jdk/pull/9818.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9818/head:pull/9818

PR: https://git.openjdk.org/jdk/pull/9818



More information about the hotspot-gc-dev mailing list