RFR: 8297247: Add GarbageCollectorMXBean for Remark and Cleanup pause time in G1 [v4]
Yude Lin
duke at openjdk.org
Mon Dec 5 03:38:08 UTC 2022
On Fri, 2 Dec 2022 14:06:16 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Yude Lin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Suggested changes to tests
>
> src/hotspot/share/gc/g1/g1MonitoringSupport.cpp line 371:
>
>> 369: G1MonitoringScope(monitoring_support,
>> 370: monitoring_support->_incremental_collection_counters,
>> 371: &monitoring_support->_incremental_memory_manager,
>
> Preexisting: it's slightly odd that one is a pointer and the other not. I wonder if both can be non-pointer.
This can be considered in another CR I think, together with the renaming of these variables, proposed in an earlier comment.
-------------
PR: https://git.openjdk.org/jdk/pull/11341
More information about the hotspot-gc-dev
mailing list