RFR: JDK-8298138: Shenandoah: HdrSeq asserts "sub-bucket index (512) overflow for value ( 1.00)" [v2]

[Y. Srinivas Ramakrishna]

On Tue, 6 Dec 2022 11:34:16 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Y. Srinivas Ramakrishna has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   - Copyright dates etc.
>>   - include reorder to alphabetic; don't use/include std:: namespace.
>
> src/hotspot/share/gc/shenandoah/shenandoahNumberSeq.hpp line 58:
> 
>> 56: // It has very low memory requirements, and is thread-safe. When accuracy
>> 57: // is not needed, it is preferred over HdrSeq.
>> 58: class BinaryMagnitudeSeq : public CHeapObj<mtInternal> {
> 
> What is the relevance of this change? Also, if it *is* necessary, then it should be mtGC.

Wanted a spec for allocation for correct accounting.

Changed to mtGC; thanks!

> test/hotspot/gtest/gc/shenandoah/test_shenandoahNumberSeq.cpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved.
> 
> The copyright should be 2022.

Fixed; thanks for the catch!

-------------

PR: https://git.openjdk.org/jdk/pull/11524